Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dict_to_json bug #54

Closed
smangham opened this issue Feb 19, 2018 · 2 comments
Closed

dict_to_json bug #54

smangham opened this issue Feb 19, 2018 · 2 comments

Comments

@smangham
Copy link
Contributor

There's a bug in dict_to_json that prevents linking from the json data back to node data.
The json for a given node is defined as "name": "node_id" when it should actually be "name": node_id. I've made a quick fix.

@sauln
Copy link
Member

sauln commented Feb 19, 2018

Thanks for this catch!

Do you think there is a unit test that could have caught this? I don't think we have any tests that probe the visualization functionality.

@MLWave
Copy link
Member

MLWave commented Feb 19, 2018

It took a while, but I've seen the beauty of tests now. I'll work to get global - and especially visualization coverage up.

And thanks!

@sauln sauln closed this as completed Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants