Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random seed to shape constructors #7

Merged
merged 2 commits into from
Nov 12, 2020

Conversation

catanzaromj
Copy link
Contributor

Raised in #5, this adds a random seed parameter to the shape constructors. This change is easy enough to implement in the other methods of the package if desired. I found setting the random seed to be especially useful for benchmarking my own code and thought others might benefit from it as well.

@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@05af7cd). Click here to learn what that means.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #7   +/-   ##
=========================================
  Coverage          ?   86.92%           
=========================================
  Files             ?        6           
  Lines             ?      153           
  Branches          ?       13           
=========================================
  Hits              ?      133           
  Misses            ?       15           
  Partials          ?        5           
Impacted Files Coverage Δ
tadasets/shapes.py 69.69% <90.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05af7cd...c29678c. Read the comment docs.

@sauln
Copy link
Member

sauln commented Nov 11, 2020

This is great, thank you! It looks like the travis tests are a bit backed up, maybe travis is having some availability issues? Once they are done I see no reason not to merge this.

@ctralie
Copy link
Member

ctralie commented Nov 12, 2020 via email

@sauln sauln merged commit bbc3162 into scikit-tda:master Nov 12, 2020
@catanzaromj catanzaromj deleted the add_random_seed branch November 13, 2020 02:22
@catanzaromj catanzaromj restored the add_random_seed branch January 8, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants