Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datamancer breaks nim CI #10

Closed
timotheecour opened this issue Jul 4, 2021 · 4 comments
Closed

datamancer breaks nim CI #10

timotheecour opened this issue Jul 4, 2021 · 4 comments

Comments

@timotheecour
Copy link

timotheecour commented Jul 4, 2021

@Vindaar
how come nimble search datamancer doesn't list this?
also:
https://github.com/nim-lang/Nim/pull/18384/checks?check_run_id=2980455174

PASS: [7/35] fusion c                                                     (20.13 sec)
  FAIL: [8/35] ggplotnim c                                                  (59.81 sec)
  Test "ggplotnim" in category "nimble-packages"
  Failure: reBuildFailed
  nim c -d:noCairo -r tests/tests.nim
  Hint: used config file '/Users/runner/work/Nim/Nim/config/nim.cfg' [Conf]
  Hint: used config file '/Users/runner/work/Nim/Nim/config/config.nims' [Conf]
  Hint: used config file '/Users/runner/work/Nim/Nim/pkgstemp/ggplotnim/tests/config.nims' [Conf]
  .........................................................................................................................
  Compiling draw as a dummy proc
  .......
  /Users/runner/.nimble/pkgs/nimblas-0.2.2/nimblas/private/common.nim(50, 7) Hint: Using BLAS library with name: libblas.dylib [User]
  ........................................................................................................................
  /Users/runner/.nimble/pkgs/nimlapack-0.2.0/nimlapack.nim(19, 7) Hint: Using LAPACK library with name: liblapack.dylib [User]
  ........................................................................
  /Users/runner/.nimble/pkgs/datamancer-0.1.7/datamancer/dataframe.nim(1435, 29) template/generic instantiation of `{}` from here
  /Users/runner/.nimble/pkgs/datamancer-0.1.7/datamancer/formula.nim(818, 12) Warning: What kind? nnkIdent in node false [User]
  /Users/runner/.nimble/pkgs/datamancer-0.1.7/datamancer/dataframe.nim(1435, 29) template/generic instantiation of `{}` from here
  /Users/runner/.nimble/pkgs/datamancer-0.1.7/datamancer/formula.nim(818, 12) Warning: What kind? nnkBracketExpr in node df[localCol][idx] [User]
  FormulaNode(name: "(== isNull(df[localCol][idx]).toBool false)",
              colName: "(== isNull(df[localCol][idx]).toBool false)",
              kind: fkVector, resType: toColKind(type(bool)), fnV: proc (
      df: DataFrame): Column =
    let localColT = df[localCol, Value]
    var res = newTensor[bool](df.len)
    for idx in 0 ..< df.len:
      res[idx] = isNull(localColT[idx]).toBool == false
    result = toColumn res)
  .....
  /Users/runner/work/Nim/Nim/pkgstemp/ggplotnim/src/ggplotnim/ggplot_types.nim(509, 3) Error: not all cases are covered; missing: {fkNone}
  
  PASS: [9/35] httpauth c                                                   ( 7.15 sec)
@Vindaar
Copy link
Member

Vindaar commented Jul 4, 2021

  1. This isn't a datamancer issue, but a ggplotnim one. The datamancer output you see there is still just a bunch of macro output that I print. It's the result of a f{} macro.
  2. The underlying issue has already been fixed here:
    Vindaar/ggplotnim@989a8b0

No idea why the CI isn't picking up ggplotnim version v0.4.3 though. It was tagged here:
Vindaar/ggplotnim@fed986c

how come nimble search datamancer doesn't list this?

Uhm, also no idea. Let me check. It was merged into packages.json here:
nim-lang/packages@9c49e83

I have the bad feeling nimble is treating the URL as case sensitive. Because I noticed that my PR to the packages repo includes lowercase names in the URL... I'll make a PR to see if that fixes at least this problem.
It's very weird though, because installing datamancer as a dependency in CI via nimble works perfectly fine.

@Vindaar
Copy link
Member

Vindaar commented Jul 4, 2021

Uhm, I can't even install any of my other packages using nimble anymore. No idea what got screwed up in the packages.json file or wherever.

@Vindaar
Copy link
Member

Vindaar commented Jul 4, 2021

Yeah, something is borked. nimble list only lists 311 packages.

@Vindaar
Copy link
Member

Vindaar commented Jul 4, 2021

Nevermind the datamancer nimble stuff. My nimble installation was borked. Works fine for me.

@Vindaar Vindaar closed this as completed Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants