Unit tests for lib.config #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def _compare_attributes(self, config, config_dict): | ||
| ntools.eq_(len(config.__dict__), | ||
| len(self.ATTRS_TO_KEYS), | ||
| "Unequal number of keys/attributes: is something missing?") |
There was a problem hiding this comment.
This can possibly by simplified to:
ntools.assert_dict_equal(config.dict, self.ATTRS_TO_KEYS)
There was a problem hiding this comment.
That's not really what I want. First, I compare their length, then I check that config object and config_dict dict has the same values for the corresponding attribute/key. For example I check that config.master_of_gen_key == config_dict['MasterOFGKey'].
|
Thanks for your comments, Stephen! Turns out these mocks are quite powerful if used right 👍 |
|
No way! I am not merging anything like this without @kormat. |
|
(Just a quick note that i am on holidays until next thursday, sorry for the delay :) |
| def test_basic(self): | ||
| cfg = Config() | ||
| cfg.parse_dict(self.config_json) | ||
| self._compare_attributes(cfg, self.config_json) |
There was a problem hiding this comment.
As this is now the only place that _compare_attributes is called from, it probably makes sense to just move it into this test class.
|
One small comment, otherwise LGTM :) |
|
Updated! |
|
(For #129) |
FR4NK-W
pushed a commit
to FR4NK-W/osourced-scion
that referenced
this pull request
Feb 14, 2017
Unit tests for lib.config
JordiSubira
added a commit
to JordiSubira/scion
that referenced
this pull request
Nov 15, 2022
* add convenience method to serrors.List * WIP keeper and manager restructuring * WIP keeper and manager restructuring * WIP keeper and manager restructuring * WIP keeper and manager restructuring * WIP fix keeper tests * recreate mocks * WIP remove unused code * fix keeper tests * manager can delete expired indices * delete expired indices on startup * fix bug removing active indices * add test checking removing active indices * manager waits until operator ready * rename store test to performance test * reenable basic store test * Fix two bugs in initiator. 1. The keeper did not set the index of the local reservation to the appropriate state before (or after) calling the store to confirm or activate indices. 2. The keeper didn't access its local entries with a pointer, but value copy. * Make seg.Index.state public * When manager or store fail, rollback all changes. Using the simplified State and SetIndexInactive, from the manager or keeper, ensure that all local indices and reservations are rolled back to the original state before the store or manager failed. * add empty store test * Fix steps if down path. RawPath --> TransportPath. When dealing with a down path SegR, the steps are always stored in the direction of the reservation. The steps are expected in the direction of the control plane messaging for init confirm and init activate index. The manager and keeper are in charge to revert the steps whenever initializing/triggering a reservation or index. Rename RawPath to TransportPath in SegR and its setup request. * simplify some code * Do not log message for persistent quic when idle. When the persistent quic client tries to reuse a session, it might get an error of the net.Error type, with Timetout true. In this case, just ignore the error and don't print anything. * Add hop fields at the initiator AS. Also compute the colibri path on activation. * Remove duplicated Ingress,Egress fields from SegR. Update tests. * SegRs store only colibri transport paths. Initialization doesn't need a path, unless it is colibri. Store accepts only colibri paths, or nil. Don't create steps from snet paths. Remove panic() from tests. Adapt tests. * Transport path validation happens only if colibri path. * cleanup * cleanup rest of slayerspath.Path wrong uses in colibri * Fix some bugs/quirks. Reverse a nil path returns nil. Restore 0 bytes returns nil path. Client operator uses colibri if present. * Temporarily patch BUG involving colibri transport. When contacting the next colibri service using a colibri path, at a stitching point, the RPC seems to never arrive at the destination. Patch for now using nil, which triggers the operator to use a regular scion path. * Review use of rawPath in colibri code. Whenever it is the transport, rename it to transportPath. * refactor manager to serviceProvider interface * rename to ServiceFacilitator * Fixes from review. Simplified activateIndex in keeper. Fixed down-path reservations not initializable by core ASes. CurrentStep is always modified in the service. Fix some comments. Simplify some if-else conditions. Move SnetToDataplanePath to snet/path. * from review * split DeriveColibriPath() * adapt logic DeriveColibriPathAtDestination Co-authored-by: Jordi Subirà Nieto <jordi.subira.nieto@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of unit tests for
lib.config.