Unit tests for lib/packet/scion.py #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratyakshs
force-pushed
the
unit_test_scion
branch
from
b717a7a
to
5b257f0
Compare
| return req | ||
|
|
||
| def pack(self): | ||
| self.payload = struct.pack("HH", self.reply_id, self.request_id) | ||
| self.payload = struct.pack("!HH", self.reply_id, self.request_id) |
There was a problem hiding this comment.
After seeing the sorts of changes needed for this, i would prefer it was in a separate PR
There was a problem hiding this comment.
Here you go: #209
| @@ -1,4 +1,4 @@ | |||
| # Copyright 2014 ETH Zurich | |||
| # Copyright 2015 ETH Zurich | |||
There was a problem hiding this comment.
I don't know the exact legal rules here, but i would leave the year untouched.
|
Ok, finished this review pass, with mostly minor comments. |
pratyakshs
force-pushed
the
unit_test_scion
branch
from
e030af2
to
a2729fd
Compare
|
@kormat , I think this is complete, you can have a look. |
kormat
changed the title
| hdr.common_hdr.total_len = 200 | ||
| path = MagicMock(spec_set=['pack']) | ||
| path.pack.return_value = b'packed_path' | ||
| hdr.set_path(path) |
There was a problem hiding this comment.
Need an assertion that pack.pack was called
pratyakshs
force-pushed
the
unit_test_scion
branch
from
15f31af
to
69472e8
Compare
| scion_common_hdr.return_value = common_hdr | ||
| scion_common_hdr.LEN = 2 | ||
| scion_addr.side_effect = ['src_addr', 'dst_addr'] | ||
| ntools.eq_(hdr._parse_common_hdr(data, 2), 2 + 2 + 3 + 5) |
There was a problem hiding this comment.
I would suggest changing the initial offset to 1, so it's easier to see where the result numbers come from.
In TestSIONHeaderParseCommonHdr.test
|
LGTM, nice work :) |
kormat
added a commit
that referenced
this pull request
Jun 30, 2015
Unit tests for lib/packet/scion.py
FR4NK-W
pushed a commit
to FR4NK-W/osourced-scion
that referenced
this pull request
Feb 14, 2017
Unit tests for lib/packet/scion.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(work in progress)@kormat, this is ready for a review.
lib.packet.opaque_fieldshould come beforelib.packet.pathpack()src_addr_lencomes beforedst_addr_lenscion_common_hdr.assert_called_once_withis still needed, to check thatnext_hdrdoes default to 0.path=None, _path=something, this test currently coverspath=something, _path=something, but currently nothing covers the_path=Nonecase. I would change this test to cover that.self._extension_hdrscontaining items.self.pop_ext_hdr()call, how can I ensure that the while loop is terminated?spect_setshould bespec_set**kwargsargument, that will silently accept any unknown keyword args, which is why it was hiddenappend_ext_hdris using addition, and not just settingtotal_lenequal tolen(ext_hdr)=+0x0102and0x0304'data'pack.packwas called