Fix topo_br_reload_if_* acceptance tests #3096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes `topo_br_reload_if_*` test to go into a valid state faster so that no revocations are issued. The log checking is moved out so that we can make sure that logs have been flushed. Also improve error msg of PS and add a TODO in segfetcher.
oncilla
approved these changes
Sep 5, 2019
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
acceptance/topo_br_reload_util/util.sh, line 41 at r1 (raw file):
set -e ./scion.sh run nobuild ./tools/dc start tester*
nice catch 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sleeps to make sure revocation is expired before checking connectivity again.
Also improve error msg of PS and add a TODO in segfetcher.
This change is