Update to tagged quic-go release v0.14.0 #3543
Conversation
FR4NK-W
force-pushed
the
update_to_quic-go_0.14.0
branch
2 times, most recently
from
adbf791
to
3d52fb6
Compare
This comment has been minimized.
This comment has been minimized.
FR4NK-W
force-pushed
the
update_to_quic-go_0.14.0
branch
from
2f7dac2
to
01f2872
Compare
Also update go_deps.bzl Update gazelle version
FR4NK-W
force-pushed
the
update_to_quic-go_0.14.0
branch
from
01f2872
to
3b71373
Compare
There was a problem hiding this comment.
Reviewed 12 of 12 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @FR4NK-W and @scrye)
go/examples/pingpong/pingpong.go, line 249 at r1 (raw file):
} qstream, err := c.qsess.OpenStreamSync(context.TODO())
I think in here you can just use context.Background()
go/lib/infra/rpc/rpc.go, line 66 at r1 (raw file):
} for { session, err := s.listener.Accept(context.TODO())
context.Background here and below.
FR4NK-W
force-pushed
the
update_to_quic-go_0.14.0
branch
from
5b08cf9
to
f549339
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @scrye)
There was a problem hiding this comment.
Reviewed 1 of 2 files at r3.
Reviewable status: 12 of 13 files reviewed, all discussions resolved (waiting on @lukedirtwalker and @scrye)
There was a problem hiding this comment.
Reviewed 1 of 2 files at r3.
Reviewable status:
Bump quic go to latest release v0.15.5. Update to changes in quic-go API: * Provide context in various API calls. * `session.Close()` is gone, now there is only `session.CloseWithError(errorNoError, "")` Handle this no-error error (by ignoring it) in pingpong. Co-authored-by: FR4NK-W <wirzf@inf.ethz.ch> Replaces #3543
|
This is replaced by #3732 |
Update go.mod github.com/lucas-clemente/quic-go v0.14.0
Also update go_deps.bzl accordingly
This change is