RELION_CUDA_BIN definition error

[wlugmayr]

scipion3 installp --checkUpdates
Scipion v3.0.13 - Eugenius
Error retrieving plugin Relion binaries: CUDA_LIB (or RELION_CUDA_LIB) is defined, but not CUDA_BIN (or RELION_CUDA_BIN), please execute scipion config --update

when adding RELION_CUDA_BIN it works.

but i get an error when calling:
scipion3 config --update
In section PLUGINS, variable RELION_CUDA_BIN exists in the configuration file but not defined by any package.

[azazellochg]

@pconesa I'm looking at this. Does it still make sense to ask for both vars defined (https://github.com/scipion-em/scipion-app/blob/devel/scipion/install/funcs.py#L784)? Quite often nvcc would be in your PATH already..

[pconesa]

I actually don't know who needs both? Xmipp?

I guess most of them use CUDA_LIB but nor CUDA_BIN?

I'm also not sure is we should raise an exception in case they are not defined.

[azazellochg]

CUDA_BIN is only required to find nvcc for compilation, so xmipp has it's own XMIPP_CUDA_BIN. Relion uses nvcc as well, if there's no CUDA_BIN then it will look at the PATH. Once binaries are compiled this CUDA_BIN is no longer used...

My point was that we may not need to check if both vars are defined, just make sure that paths are added correctly when any of them is defined.

[pconesa]

make sense to me. @delarosatrevin ? I think he added this piece of code, should we at least relax it?
We can turn the raise into log lines/warnings? or even as Grigory suggests, just check the paths in check the variable/s exists.

[delarosatrevin]

I can't remember if I added this code. Anyway, I agree with @azazellochg suggestion, if defined, we use it...if not, nothing happens.

[pconesa]

ok