Skip to content

Commit

Permalink
clean up setup.py as best as possible (#562)
Browse files Browse the repository at this point in the history 
* clean up setup.py as best as possible

* fix typo

* fix another path issue

* cosmetic changes

* use sys.exit instead of quit in setup.py
  • Loading branch information
@mattmilten
mattmilten committed Feb 6, 2022
1 parent e51f7fb commit 961eca6
Showing 1 changed file with 68 additions and 68 deletions.
136 changes: 68 additions & 68 deletions setup.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,128 +2,128 @@
import os, platform, sys, re

# look for environment variable that specifies path to SCIP
scipoptdir = os.environ.get('SCIPOPTDIR', '').strip('"')
scipoptdir = os.environ.get("SCIPOPTDIR", "").strip('"')

extra_compile_args = []
extra_link_args = []

# if SCIPOPTDIR is not set, we assume that SCIP is installed globally
if not scipoptdir:
includedir = '.'
libdir = '.'
libname = 'scip'
if platform.system() in ['Windows']:
libname = 'libscip'
print('Assuming that SCIP is installed globally.\n')
includedir = "."
libdir = "."
libname = "libscip" if platform.system() in ["Windows"] else "scip"
print("Assuming that SCIP is installed globally.\n")

else:
# determine include directory
if os.path.exists(os.path.join(scipoptdir, 'src')):
if os.path.exists(os.path.join(scipoptdir, "src")):
# SCIP seems to be installed in place; check whether it was build using make or cmake

if os.path.exists(os.path.join(scipoptdir, 'src/scip')):
if os.path.exists(os.path.join(scipoptdir, "src", "scip")):
# SCIPOPTDIR pointed to the main source directory
includedir = os.path.abspath(os.path.join(scipoptdir, 'src'))
includedir = os.path.abspath(os.path.join(scipoptdir, "src"))
else:
# SCIPOPTDIR probably pointed to a cmake build directory; try one level up
if os.path.exists(os.path.join(scipoptdir, '../src/scip')):
includedir = os.path.abspath(os.path.join(scipoptdir, '../src'))
if os.path.exists(os.path.join(scipoptdir, "..", "src", "scip")):
includedir = os.path.abspath(os.path.join(scipoptdir, "..", "src"))
else:
print('Location SCIPOPTDIR does not contain a src/scip directory; exiting because we cannot not find the include files.')
quit(1)
sys.exit(f"SCIPOPTDIR={scipoptdir} does not contain a src/scip directory.")

else:
# assume that SCIP is installed on the system
if os.path.exists(os.path.join(scipoptdir, 'include')):
includedir = os.path.abspath(os.path.join(scipoptdir, 'include'))
if os.path.exists(os.path.join(scipoptdir, "include")):
includedir = os.path.abspath(os.path.join(scipoptdir, "include"))
else:
print('Location SCIPOPTDIR does not contain an include directory; exiting because we cannot not find the include files.')
quit(1)
sys.exit(f"SCIPOPTDIR={scipoptdir} does not contain an include directory.")

# determine library
if os.path.exists(os.path.join(scipoptdir, 'lib/shared/libscip.so')):
if os.path.exists(os.path.join(scipoptdir, "lib", "shared", "libscip.so")):
# SCIP seems to be created with make
libdir = os.path.abspath(os.path.join(scipoptdir, 'lib/shared'))
libname = 'scip'
extra_compile_args.append('-DNO_CONFIG_HEADER')
libdir = os.path.abspath(os.path.join(scipoptdir, "lib", "shared"))
libname = "scip"
extra_compile_args.append("-DNO_CONFIG_HEADER")
# the following is a temporary hack to make it compile with SCIP/make:
extra_compile_args.append('-DTPI_NONE') # this is just a guess, if other TPIs are used, please modify
extra_compile_args.append("-DTPI_NONE") # if other TPIs are used, please modify
else:
# assume that SCIP is installed on the system
libdir = os.path.abspath(os.path.join(scipoptdir, 'lib'))
libname = 'scip'
if platform.system() in ['Windows']:
libname = 'libscip'
libdir = os.path.abspath(os.path.join(scipoptdir, "lib"))
libname = "libscip" if platform.system() in ["Windows"] else "scip"

print('Using include path <%s>.' % includedir)
print('Using SCIP library <%s> at <%s>.\n' % (libname,libdir))
print(f"Using include path {includedir}.")
print(f"Using SCIP library {libname} at {libdir}.\n")

# set runtime libraries
if platform.system() in ['Linux', 'Darwin']:
extra_link_args.append('-Wl,-rpath,'+libdir)
if platform.system() in ["Linux", "Darwin"]:
extra_link_args.append(f"-Wl,-rpath,{libdir}")

# enable debug mode if requested
if "--debug" in sys.argv:
extra_compile_args.append('-UNDEBUG')
extra_compile_args.append("-UNDEBUG")
sys.argv.remove("--debug")

use_cython = True

packagedir = os.path.join('src', 'pyscipopt')
packagedir = os.path.join("src", "pyscipopt")

with open(os.path.join(packagedir, '__init__.py'), 'r') as initfile:
version = re.search(r'^__version__\s*=\s*[\'"]([^\'"]*)[\'"]',
initfile.read(), re.MULTILINE).group(1)
with open(os.path.join(packagedir, "__init__.py"), "r") as initfile:
version = re.search(
r'^__version__\s*=\s*[\'"]([^\'"]*)[\'"]', initfile.read(), re.MULTILINE
).group(1)

try:
from Cython.Build import cythonize
except ImportError as err:
# if cython is not found _and_ src/pyscipopt/scip.c does not exist then we cannot do anything.
if not os.path.exists(os.path.join(packagedir, 'scip.c')):
print('Cython is required')
quit(1)
if not os.path.exists(os.path.join(packagedir, "scip.c")):
sys.exit("Cython is required.")
use_cython = False

# if src/pyscipopt/scip.pyx does not exist then there is no need for using cython
if not os.path.exists(os.path.join(packagedir, 'scip.pyx')):
if not os.path.exists(os.path.join(packagedir, "scip.pyx")):
use_cython = False

ext = '.pyx' if use_cython else '.c'
ext = ".pyx" if use_cython else ".c"

extensions = [Extension('pyscipopt.scip', [os.path.join(packagedir, 'scip'+ext)],
include_dirs=[includedir],
library_dirs=[libdir],
libraries=[libname],
extra_compile_args = extra_compile_args,
extra_link_args=extra_link_args
)]
extensions = [
Extension(
"pyscipopt.scip",
[os.path.join(packagedir, f"scip{ext}")],
include_dirs=[includedir],
library_dirs=[libdir],
libraries=[libname],
extra_compile_args=extra_compile_args,
extra_link_args=extra_link_args,
)
]

if use_cython:
extensions = cythonize(extensions, compiler_directives={'language_level': 3})
extensions = cythonize(extensions, compiler_directives={"language_level": 3})

with open('README.md') as f:
with open("README.md") as f:
long_description = f.read()

setup(
name='PySCIPOpt',
name="PySCIPOpt",
version=version,
description='Python interface and modeling environment for SCIP',
description="Python interface and modeling environment for SCIP",
long_description=long_description,
long_description_content_type='text/markdown',
url='https://github.com/SCIP-Interfaces/PySCIPOpt',
author='Zuse Institute Berlin',
author_email='scip@zib.de',
license='MIT',
long_description_content_type="text/markdown",
url="https://github.com/SCIP-Interfaces/PySCIPOpt",
author="Zuse Institute Berlin",
author_email="scip@zib.de",
license="MIT",
classifiers=[
'Development Status :: 4 - Beta',
'Intended Audience :: Science/Research',
'Intended Audience :: Education',
'License :: OSI Approved :: MIT License',
'Programming Language :: Python :: 3',
'Programming Language :: Cython',
'Topic :: Scientific/Engineering :: Mathematics'],
"Development Status :: 4 - Beta",
"Intended Audience :: Science/Research",
"Intended Audience :: Education",
"License :: OSI Approved :: MIT License",
"Programming Language :: Python :: 3",
"Programming Language :: Cython",
"Topic :: Scientific/Engineering :: Mathematics",
],
ext_modules=extensions,
install_requires=['wheel'],
packages=['pyscipopt'],
package_dir={'pyscipopt': packagedir},
package_data={'pyscipopt': ['scip.pyx', 'scip.pxd', '*.pxi']}
install_requires=["wheel"],
packages=["pyscipopt"],
package_dir={"pyscipopt": packagedir},
package_data={"pyscipopt": ["scip.pyx", "scip.pxd", "*.pxi"]},
)

0 comments on commit 961eca6

Please sign in to comment.