Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipelines #834

Merged
merged 6 commits into from
Apr 2, 2024
Merged

Fix pipelines #834

merged 6 commits into from
Apr 2, 2024

Conversation

mmghannam
Copy link
Member

@mmghannam mmghannam commented Apr 2, 2024

  • Use backwards compatible type hints.
  • Install bison in macos pipeline.
  • Install locales needed by tests in ubuntu integration test.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 52.29%. Comparing base (cc24fc8) to head (dcf259a).

Files Patch % Lines
src/pyscipopt/recipes/piecewise.py 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #834      +/-   ##
==========================================
- Coverage   52.30%   52.29%   -0.02%     
==========================================
  Files          19       19              
  Lines        3904     3905       +1     
==========================================
  Hits         2042     2042              
- Misses       1862     1863       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmghannam
Copy link
Member Author

Should be working now with these changes https://github.com/scipopt/PySCIPOpt/actions/runs/8528377932?pr=834

Copy link
Collaborator

@Joao-Dionisio Joao-Dionisio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, Mo! Genuine question, why do you prefer typing List to regular list?

@mmghannam
Copy link
Member Author

mmghannam commented Apr 2, 2024

It looks good to me, Mo! Genuine question, why do you prefer typing List to regular list?

I don't 😄 It's just that it works with older python versions.

@Joao-Dionisio Joao-Dionisio merged commit eff4bd0 into master Apr 2, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants