Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for pt_PT in test_locale #841

Merged
merged 4 commits into from
Apr 7, 2024
Merged

Add check for pt_PT in test_locale #841

merged 4 commits into from
Apr 7, 2024

Conversation

Joao-Dionisio
Copy link
Collaborator

Fix #840

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.29%. Comparing base (6a17c96) to head (2fe3da3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #841   +/-   ##
=======================================
  Coverage   52.29%   52.29%           
=======================================
  Files          19       19           
  Lines        3905     3905           
=======================================
  Hits         2042     2042           
  Misses       1863     1863           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mmghannam mmghannam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks @Joao-Dionisio :)

@mmghannam
Copy link
Member

I removed the locale setup from the integration test workflow, didn't want to remove it from the PR (coverage) pipelines since it should be running everything there. But we also need another test run to see if the skip works 😄

@mmghannam mmghannam merged commit 32caac7 into master Apr 7, 2024
1 check passed
@mmghannam mmghannam deleted the skip-locale branch April 7, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 test fails: locale.Error: unsupported locale setting
2 participants