Adds bipartite graph function #874
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """Returns the degree of parallelism between hyplerplanes. 1 if perfectly parallel, 0 if orthognal. | ||
| 101 in this case is an 'e' (euclidean) in ASCII. The other accpetable input is 100 (d for discrete).""" | ||
| """Returns the degree of parallelism between hyplerplanes. 1 if perfectly parallel, 0 if orthogonal. | ||
| 101 in this case is an 'e' (euclidean) in ASCII. The other acceptable input is 100 (d for discrete).""" |
There was a problem hiding this comment.
I would also add how this is calculated, degree of parallelism is too vague. The SCIP documentation has "returns the degree of parallelism between the hyperplanes defined by the two row vectors v, w: p = |vw|/(|v||w|); the hyperplanes are parallel, iff p = 1, they are orthogonal, iff p = 0"
|
|
||
| def getBipartiteGraphRepresentation(self, prev_col_features=None, prev_edge_features=None, prev_row_features=None, | ||
| static_only=False, suppress_warnings=False): | ||
| """This function generated the bipartite graph representation of an LP, which was first used in |
There was a problem hiding this comment.
generates instead of generated. Or if you want to say that it generated the representation first used in the paper, I think you need to say something like "... of an LP used in the following paper". Not a grammar expert though, so might be wrong.
|
|
||
| for i in range(100): | ||
| more_vars.append(scip.addVar(vtype="I", lb=-52, ub=10)) | ||
| scip.addCons(quicksum(v for v in more_vars[50::2]) <= (40 - i) * quicksum(v for v in more_vars[405::2])) |
There was a problem hiding this comment.
Same thing with more_vars[405::2]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch shouldn't be merged until the strong branch one is complete. A potential user raised concerns about such functionality not being present in PySCIPOpt directly and that he had to use third party software. After thinking about it a bit, it is just a glorified feature retrieval function. So I thought I'd spin up a quick version.