Merge branch 'fix-github-lpreader-issue' into 'v80-bugfix'

Fix github lpreader issue See merge request integer/scip!2797
scipopt · Jan 14, 2022 · c636343 · c636343
2 parents 345e79c + 2c971a5
commit c636343
Showing 1 changed file with 18 additions and 0 deletions.
diff --git a/src/scip/reader_lp.c b/src/scip/reader_lp.c
@@ -1026,6 +1026,12 @@ SCIP_RETCODE readCoefficients(
       /* check if we read a sign */
       if( isSign(lpinput, &coefsign) )
       {
+         if( havevalue )
+         {
+            syntaxError(scip, lpinput, "sign after value without variable.");
+            return SCIP_OKAY;
+         }
+
          SCIPdebugMsg(scip, "(line %d) read coefficient sign: %+d\n", lpinput->linenumber, coefsign);
          havesign = TRUE;
          continue;
@@ -1053,6 +1059,18 @@ SCIP_RETCODE readCoefficients(
             return SCIP_OKAY;
          }
 
+         if( havevalue )
+         {
+            syntaxError(scip, lpinput, "no constant values allowed for constraints in lp file format");
+            return SCIP_OKAY;
+         }
+
+         if( havesign )
+         {
+            syntaxError(scip, lpinput, "constaint has sign without a variable");
+            return SCIP_OKAY;
+         }
+
          /* put the sense back onto the token stack */
          pushToken(lpinput);
          break;