New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename plot module to plotting #1696
Conversation
scipp/src/plot/plot_matplotlib.py | ||
scipp/src/plot/plot.py | ||
scipp/src/plot/tools.py | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that they are not used at all?
CMake apparently finds and copies all the files in the subdirectories.
See discussion on Slack (scipp channel)
@OwenArnold how would this impact the CI chain we have with the |
#1494 (comment) describes current working. Yes correct. If you introduce breaking functionality in scipp, we don't see the effect downstream until the release is made. We could potentially have a |
Do not merge right now (converted to draft). This will break the IKON20 Python course, and I don't know when/if the images will be rebuilt. |
@nvaytet Or should we merge, fix the notebooks, and ask Torben to rebuild the image? |
I don't really mind. I'll ask Torben if there is still time to rebuild the image. |
We now import only the
plot
function from theplotting
module in the scipp__init__.py
.This means we can now simply do
sc.plot(mydata)
instead ofsc.plot.plot(mydata)
.The only other things in the
plotting
module that were being imported were some mostly unused shortcuts to various plot projections. These have now been removed.This also fixes the mpl plots that were not showing in the binned_data notebook for example.