Skip to content

Commit

Permalink
TST: flaky TestSOSFreqz::test_fs_param
Browse files Browse the repository at this point in the history
* deals with the 1 of the 2 Apple silicon
test failures in gh-18732

* I was able to reproduce locally, but because
it was flaky I needed `pytest-repeat` for
consistent failure:
`CC=clang CXX=clang++ FC=gfortran-12 python dev.py test -t scipy/signal/tests/test_filter_design.py::TestSOSFreqz::test_fs_param -- --count=200`

* I verified that with the provided patch/`atol` bump,
we consistently pass even with `2000` repeats

[skip circle]
  • Loading branch information
tylerjereddy committed Jun 25, 2023
1 parent 7c317cb commit db11851
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scipy/signal/tests/test_filter_design.py
Original file line number Diff line number Diff line change
Expand Up @@ -1041,7 +1041,7 @@ def test_fs_param(self):
# N = None, whole=True
w1, h1 = sosfreqz(sos, whole=True, fs=fs)
w2, h2 = sosfreqz(sos, whole=True)
assert_allclose(h1, h2)
assert_allclose(h1, h2, atol=1e-27)
assert_allclose(w1, np.linspace(0, fs, 512, endpoint=False))

# N = 5, whole=False
Expand Down

0 comments on commit db11851

Please sign in to comment.