New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linprog(method='revised simplex') doctest bug #10124
Comments
We are at RC phase to catch these post branch issues. If needed, which seems so, Tyler would backport it |
If you open a PR also mark it backport candidate and remove it here maybe? |
Will try to do this weekend. Still scheduled to release 5/20? |
Hoping we can stick to the schedule yes, but the SkylakeX / AVX OpenBLAS issues have me a little concerned. The PR should be to master, then we can backport if that seems appropriate--tag the PR to master with backport label so I can see it in the list when I'm doing release duties next time. |
* BUG: fix linprog revised simplex docstring problem failure linprog with method='revised simplex' failed docstring problem. The cause was that option 'disp'=True executes _postsolve, which changes the solution vector. Simple fix was to copy the solution vector before passing it into _postsolve. * BUG: optimize: adds tests for bug #10124 * BUG: optimize: fix linprog docstring failure for interior-point * BUG:optimize:fix linprog interior-point not calling callback on iteration 0 * ENH:optimize:linprog_ip convert displayed variables to float in _display_iter * ENH:optimize:_linprog_rs use new _postsolve copy option
* BUG: fix linprog revised simplex docstring problem failure linprog with method='revised simplex' failed docstring problem. The cause was that option 'disp'=True executes _postsolve, which changes the solution vector. Simple fix was to copy the solution vector before passing it into _postsolve. * BUG: optimize: adds tests for bug scipy#10124 * BUG: optimize: fix linprog docstring failure for interior-point * BUG:optimize:fix linprog interior-point not calling callback on iteration 0 * ENH:optimize:linprog_ip convert displayed variables to float in _display_iter * ENH:optimize:_linprog_rs use new _postsolve copy option
Apparently this was fixed on some platforms but not all. There was a mistake in
is supposed to be
|
@tylerjereddy Didn't realize we were doing a 1.3.1 shortly. Let me get a PR for this out. |
linprog
method='revised simplex'
(in the 1.3 branch) doesn't solve the example problem in the docstring. The example was supposed to be a doctest, but all the outputs were marked "# may vary", so the problem wasn't caught.I think a small bug in the phase 1 problem formulation was introduced at some point. Strangely, the issue didn't surface in any of the other tests (or the much more difficult benchmark problems). I can fix it before 1.3 and add the example as a regular test before 1.3 is released. @tylerjereddy Do I submit a PR to the "maintenance/1.3.x" branch?
Reproducing code example:
The status is 4 (algorithm reported success, but solution was infeasible).
The text was updated successfully, but these errors were encountered: