Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyflakes silently failing on travis-ci #11811

Closed
pkienzle opened this issue Apr 6, 2020 · 0 comments · Fixed by #11813
Closed

pyflakes silently failing on travis-ci #11811

pkienzle opened this issue Apr 6, 2020 · 0 comments · Fixed by #11813
Labels
Benchmarks Running, verifying or documenting benchmarks for SciPy CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure
Milestone

Comments

@pkienzle
Copy link
Contributor

pkienzle commented Apr 6, 2020

pyflakes 1.1.0 is failing with an internal error AttributeError: 'Checker' object has no attribute 'JOINEDSTR'. Version 2.1.0 runs to completion (though with many warnings, as indicated in #11529).

See also recent travis build results (even ones that pass!), such as
https://travis-ci.org/github/scipy/scipy/jobs/671749102?utm_medium=notification&utm_source=github_status (scroll to line 553).

Reproducing code example:

Follow the steps in .travis.yml on your local development machine:

pip install pyflakes==1.1.0
PYFLAKES_NODOCTEST=1 pyflakes scipy benchmarks/benchmarks

Error message:

...
scipy/linalg/tests/test_decomp.py:2448: local variable '_' is assigned to but never used
scipy/linalg/tests/test_decomp_cossin.py:8: 'block_diag' imported but unused
Traceback (most recent call last):
  File "/Users/pkienzle/conda/envs/bumps/bin/pyflakes", line 8, in <module>
    sys.exit(main())
  File "/Users/pkienzle/conda/envs/bumps/lib/python3.7/site-packages/pyflakes/api.py", line 184, in main
    warnings = checkRecursive(args, reporter)
  File "/Users/pkienzle/conda/envs/bumps/lib/python3.7/site-packages/pyflakes/api.py", line 141, in checkRecursive
    warnings += checkPath(sourcePath, reporter)
  File "/Users/pkienzle/conda/envs/bumps/lib/python3.7/site-packages/pyflakes/api.py", line 108, in checkPath
    return check(codestr, filename, reporter)
  File "/Users/pkienzle/conda/envs/bumps/lib/python3.7/site-packages/pyflakes/api.py", line 69, in check
    w = checker.Checker(tree, filename)
  File "/Users/pkienzle/conda/envs/bumps/lib/python3.7/site-packages/pyflakes/checker.py", line 329, in __init__
    self.runDeferred(self._deferredFunctions)
  File "/Users/pkienzle/conda/envs/bumps/lib/python3.7/site-packages/pyflakes/checker.py", line 366, in runDeferred
    handler()
  File "/Users/pkienzle/conda/envs/bumps/lib/python3.7/site-packages/pyflakes/checker.py", line 958, in runFunction
    self.handleNode(stmt, node)
  File "/Users/pkienzle/conda/envs/bumps/lib/python3.7/site-packages/pyflakes/checker.py", line 697, in handleNode
    handler(node)
  File "/Users/pkienzle/conda/envs/bumps/lib/python3.7/site-packages/pyflakes/checker.py", line 650, in handleChildren
    self.handleNode(node, tree)
  File "/Users/pkienzle/conda/envs/bumps/lib/python3.7/site-packages/pyflakes/checker.py", line 697, in handleNode
    handler(node)
  File "/Users/pkienzle/conda/envs/bumps/lib/python3.7/site-packages/pyflakes/checker.py", line 650, in handleChildren
    self.handleNode(node, tree)
  File "/Users/pkienzle/conda/envs/bumps/lib/python3.7/site-packages/pyflakes/checker.py", line 697, in handleNode
    handler(node)
  File "/Users/pkienzle/conda/envs/bumps/lib/python3.7/site-packages/pyflakes/checker.py", line 650, in handleChildren
    self.handleNode(node, tree)
  File "/Users/pkienzle/conda/envs/bumps/lib/python3.7/site-packages/pyflakes/checker.py", line 697, in handleNode
    handler(node)
  File "/Users/pkienzle/conda/envs/bumps/lib/python3.7/site-packages/pyflakes/checker.py", line 650, in handleChildren
    self.handleNode(node, tree)
  File "/Users/pkienzle/conda/envs/bumps/lib/python3.7/site-packages/pyflakes/checker.py", line 696, in handleNode
    handler = self.getNodeHandler(node.__class__)
  File "/Users/pkienzle/conda/envs/bumps/lib/python3.7/site-packages/pyflakes/checker.py", line 530, in getNodeHandler
    self._nodeHandlers[node_class] = handler = getattr(self, nodeType)
AttributeError: 'Checker' object has no attribute 'JOINEDSTR'

Scipy/Numpy/Python version information:

1.3.1 1.17.3 sys.version_info(major=3, minor=7, micro=3, releaselevel='final', serial=0)
@miladsade96 miladsade96 added Benchmarks Running, verifying or documenting benchmarks for SciPy CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure labels Apr 6, 2020
pkienzle pushed a commit to pkienzle/scipy that referenced this issue Apr 6, 2020
andyfaff pushed a commit that referenced this issue Apr 9, 2020
* MAINT: bump pyflakes to version 2.1.1. Closes #11811.
@tylerjereddy tylerjereddy added this to the 1.5.0 milestone Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmarks Running, verifying or documenting benchmarks for SciPy CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants