Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: lint is failing because of output to stderr #13179

Closed
andyfaff opened this issue Dec 1, 2020 · 2 comments
Closed

CI: lint is failing because of output to stderr #13179

andyfaff opened this issue Dec 1, 2020 · 2 comments
Assignees
Labels
CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure
Milestone

Comments

@andyfaff
Copy link
Contributor

andyfaff commented Dec 1, 2020

The lint on CI is currently failing because a pip install step is designed to fail if anything writes to stderr.

  - script: >-
      python -m pip install
      pycodestyle==2.5.0
      pyflakes==2.1.1
    displayName: 'Install tools'
    failOnStderr: true

However, pip is emitting a "You are using pip version 20.2.4; however, version 20.3 is available", which this step treats as an error.
I think we should remove the failOnStderr line.

@tylerjereddy

@tylerjereddy tylerjereddy added this to the 1.6.0 milestone Dec 1, 2020
@tylerjereddy tylerjereddy added the CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure label Dec 1, 2020
@tylerjereddy
Copy link
Contributor

Fixed by gh-13181

@andyfaff
Copy link
Contributor Author

andyfaff commented Dec 1, 2020

Sorry, just figured it was an easy fix. Closed in #13181.
If the pip install does fail, then the next part of the run will fail because pycodestyle won't be installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure
Projects
None yet
Development

No branches or pull requests

2 participants