Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add split normal distribution #13825

Open
keatonb opened this issue Apr 8, 2021 · 12 comments
Open

Add split normal distribution #13825

keatonb opened this issue Apr 8, 2021 · 12 comments
Labels
enhancement A new feature or improvement scipy.stats

Comments

@keatonb
Copy link

keatonb commented Apr 8, 2021

Split normal is a useful distribution that isn't currently implemented in SciPy. I will work to implement.

Split normal: https://en.wikipedia.org/wiki/Split_normal_distribution

@tupui
Copy link
Member

tupui commented Apr 8, 2021

Hi, thanks for the proposal. Usually we use first the mail-list to introduce new features like a new distribution. I invite you to post your proposal here with sound motivations (like strong literature indicating the value of the feature): https://mail.python.org/pipermail/scipy-dev/. This avoids starting to work on something and having the risk of the PR being rejected.

@tupui tupui added enhancement A new feature or improvement scipy.stats labels Apr 8, 2021
@keatonb
Copy link
Author

keatonb commented Apr 8, 2021

Good to know. I'll do that. The instructions on proposing a new distribution doesn't mention the mailing list, fyi, just says to open a GitHub issue: https://docs.scipy.org/doc/scipy/reference/dev/contributor/adding_new.html

@tupui
Copy link
Member

tupui commented Apr 8, 2021

Thanks for pointing it out. We are always looking at unifying and improving the dev docs. I will mention this.

@mdhaber
Copy link
Contributor

mdhaber commented Apr 10, 2021

@keatonb if mailing list response is positive, a good example PR for a statistical distribution - and one that may be particularly relevant because it was also for a piecewise-defined distribution - is gh-12694.

@czgdp1807
Copy link
Member

@keatonb @tupui Is this issue approved on the mailing list? If not then I can try proposing it. Please let me know.

P.S. If it's already approved then please share the link to the thread. It would be great to go through it before starting working on it.

@tupui
Copy link
Member

tupui commented Jul 2, 2021

@czgdp1807 not sure I saw such a message. You can go through the archive here https://mail.python.org/pipermail/scipy-dev/

@keatonb
Copy link
Author

keatonb commented Jul 3, 2021

@czgdp1807 sorry I didn't get around to it. Feel free to propose for this on the mailing list.

@cmdupuis3
Copy link
Contributor

Taking...

@tupui
Copy link
Member

tupui commented Aug 3, 2022

@cmdupuis3 do you mean that you are going to ask the mailing list? This is a requirement before starting any work as you can read from the previous comments.

@cmdupuis3
Copy link
Contributor

I guess so? Someone told me to try working on this at the SciPy hackathon as a good next-step issue.

Looks like the links here are out of date. Do I just start a thread on the new mailing list?

@tupui
Copy link
Member

tupui commented Aug 4, 2022

Yes sure feel free to send an email to the list 😃

@mdhaber
Copy link
Contributor

mdhaber commented Aug 4, 2022

Someone told me to try working on this at the SciPy hackathon as a good next-step issue.

Yes, that was me.

Yes, it's best to start with a post on the mailing list before starting work because ultimately it will need approval there before being merged. Better to know sooner than later.

Please see (here)[https://docs.scipy.org/doc/scipy/dev/contributor/adding_new.html#adding-a-new-statistics-distribution] for more information about adding a statistical distribution. You can also search the (closed) PRs for "asymmetric Laplace". The PR adding that is a good, recent example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or improvement scipy.stats
Projects
None yet
Development

No branches or pull requests

5 participants