Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate scipy.spatial.distance.kulsinski #15125

Closed
tupui opened this issue Nov 30, 2021 · 5 comments · Fixed by #16265
Closed

Deprecate scipy.spatial.distance.kulsinski #15125

tupui opened this issue Nov 30, 2021 · 5 comments · Fixed by #16265
Labels
deprecated Items related to behavior that has been deprecated good first issue Good topic for first contributor pull requests, with a relatively straightforward solution scipy.spatial
Milestone
1.9.0

Comments

@tupui
Copy link
Member

tupui commented Nov 30, 2021 •
edited
Loading

kulsinski has been superseded by kulczynski1 in #14588.

As per #2009 (comment)_, we should deprecate kulsinski starting with 1.9.
@tupui tupui added this to the 1.9.0 milestone Nov 30, 2021
@tupui tupui added deprecated Items related to behavior that has been deprecated good first issue Good topic for first contributor pull requests, with a relatively straightforward solution labels Nov 30, 2021
@deepakdinesh1123
Copy link
Contributor

Can I work on this issue?

@tupui
Copy link
Member Author

tupui commented Dec 1, 2021

Hi @deepakdinesh1123 thanks for the proposal. You can start but we need to wait for the branching for SciPy 1.8. It should happen next week.

@deepakdinesh1123
Copy link
Contributor

Thank you very much for giving me an opportunity to contribute.
So I should deprecate the method and refactor the code so that all occurrences of the kulsinski method are replaced by kulczynski1 right?

@tupui
Copy link
Member Author

tupui commented Dec 3, 2021

Pleasure 😃. Yes that's what's need to be done. In the main init (and other places) there are examples of decorator usage on how to deprecate something.

@deepakdinesh1123 deepakdinesh1123 mentioned this issue Dec 8, 2021
Closed
@h-vetinari
Copy link
Member

kulsinski has been superseded by kulczynski1 in #1484.

Typo: this should be #14588

@h-vetinari h-vetinari mentioned this issue Dec 30, 2021
Open
23 tasks
@h-vetinari h-vetinari mentioned this issue Mar 11, 2022
Open
31 tasks
j-bowhay added a commit to j-bowhay/scipy that referenced this issue May 24, 2022
@j-bowhay
Merge remote-tracking branch 'deepakdinesh1123/master' into scipygh-1…
fe40f45 
…5125
@j-bowhay j-bowhay mentioned this issue May 24, 2022
Merged
@h-vetinari h-vetinari mentioned this issue May 25, 2022
Closed
@smidmatej smidmatej mentioned this issue Apr 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecated Items related to behavior that has been deprecated good first issue Good topic for first contributor pull requests, with a relatively straightforward solution scipy.spatial
Projects
None yet
Milestone
1.9.0
Development

Successfully merging a pull request may close this issue.

DEP: deprecate spatial.distance.kulsinski j-bowhay/scipy
DEP: deprecate spatial.distance.kulsinski
3 participants
@tupui @h-vetinari @deepakdinesh1123