Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: comparison of optimizers in optimization guide #17404

Open
dschmitz89 opened this issue Nov 12, 2022 · 8 comments
Open

DOC: comparison of optimizers in optimization guide #17404

dschmitz89 opened this issue Nov 12, 2022 · 8 comments
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org good first issue Good topic for first contributor pull requests, with a relatively straightforward solution scipy.optimize

Comments

@dschmitz89
Copy link
Contributor

Hi everyone,

the optimization user guide currently does not contain any form of easily accessible comparison of the different solver capabilties.

I think this would be helpful for many users as the typical questions for someone looking to solve an optimization problem are (for example been requested in #16191):

  • How do I formulate my problem with this package?
  • Which solver is probably a good fit for me?

As a first start of discussion, I created a google doc table to compare the local and global solvers:
https://docs.google.com/spreadsheets/d/1PNpOcy99qfn-ip168vL4Qskc3bpybJP7e2vpuhrQKN4/edit#gid=0

Let me know if you think that an important category is missing.

@rgommers rgommers added scipy.optimize Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org labels Nov 12, 2022
@rgommers
Copy link
Member

Good idea @dschmitz89. The SciPy 1.0 paper has this table though: https://www.nature.com/articles/s41592-019-0686-2/tables/1. We should repurpose that.

@j-bowhay j-bowhay added the good first issue Good topic for first contributor pull requests, with a relatively straightforward solution label Nov 14, 2022
@ghost
Copy link

ghost commented Nov 21, 2022

Hello @dschmitz89 and @rgommers, I'll be working on this suggested enhancement and will pull when it's ready.

@lucascolley
Copy link
Member

gh-17491 worked on this and received some substantial review, but it went stale and the head repository was deleted. If anyone else would like to pick this up, it would be a good idea to look at what was done over there first.

@koko1928
Copy link

Hi everyone,

the optimization user guide currently does not contain any form of easily accessible comparison of the different solver capabilties.

I think this would be helpful for many users as the typical questions for someone looking to solve an optimization problem are (for example been requested in #16191):

  • How do I formulate my problem with this package?
  • Which solver is probably a good fit for me?

As a first start of discussion, I created a google doc table to compare the local and global solvers: https://docs.google.com/spreadsheets/d/1PNpOcy99qfn-ip168vL4Qskc3bpybJP7e2vpuhrQKN4/edit#gid=0

Let me know if you think that an important category is missing.

I think it sounds nice.

@dschmitz89
Copy link
Contributor Author

@koko1928 : would you be interested to contribute something along the lines of my table to the documentation?

@koko1928
Copy link

koko1928 commented Feb 3, 2024

@koko1928 : would you be interested to contribute something along the lines of my table to the documentation?

Hi @dschmitz89 ,

Thank you for considering my contribution. I'm definitely interested in contributing to the documentation with the comparison table you've initiated. However, before I proceed, I would appreciate some guidance on how to integrate the table into the documentation effectively. Could you provide me with some details on the preferred format and any specific documentation guidelines I should follow? Additionally, if there's any particular procedure for submitting this kind of update to the documentation, I'd like to understand that as well.

Looking forward to your response.

Best,
koko1928

@dschmitz89
Copy link
Contributor Author

@koko1928 : would you be interested to contribute something along the lines of my table to the documentation?

Hi @dschmitz89 ,

Thank you for considering my contribution. I'm definitely interested in contributing to the documentation with the comparison table you've initiated. However, before I proceed, I would appreciate some guidance on how to integrate the table into the documentation effectively. Could you provide me with some details on the preferred format and any specific documentation guidelines I should follow? Additionally, if there's any particular procedure for submitting this kind of update to the documentation, I'd like to understand that as well.

Looking forward to your response.

Best, koko1928

To get this documentation update into SciPy, you need to create a PR which will be reviewed. A good reference is our developer documentation: see here. Once you have your development environment running, hopefully you can build the documentation locally on your machine (invoke via python dev.py doc). Then have a look at the documentation guide.

The closed PR #17491 can give you an example. The trickiest part about this new table is in my opinion how to add it so that it renders nicely. Sphinx is not always the easiest tool for such tasks. If there are further questions, feel free to ping me here. :)

@koko1928
Copy link

koko1928 commented Feb 7, 2024

I created a PR. Please leave a review.

koko1928 added a commit to koko1928/scipy that referenced this issue Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org good first issue Good topic for first contributor pull requests, with a relatively straightforward solution scipy.optimize
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants