TST: SphericalVoronoi tests not sensitive to regions internal type #19177
Labels
good first issue
Good topic for first contributor pull requests, with a relatively straightforward solution
scipy.spatial
Milestone
The
regions
attribute ofSphericalVoronoi
is defined (and currently is) a "list of lists," just like the attribute sharing the same name in the more generalVoronoi
class. I noticed while working on gh-19172 last night that I could simply change this to a "list of arrays" and the full SciPy test suite would pass! This isn't desirable, since some folks may depend on that structure I suppose, and the ragged data structure doesn't gain much advantage from using arrays internally in either of those classes.Here's a sample diff that changes the return nested type without consequence:
Here's a sample test modification that catches the problem:
Perhaps I'll label this "good first issue" and suggest making the test a little more robust than just checking a single element/region.
The text was updated successfully, but these errors were encountered: