Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Missing blankspace in error message raised by cont2discrete() #20662

Closed
budjen-jovan opened this issue May 8, 2024 · 0 comments · Fixed by #20664
Closed

DOC: Missing blankspace in error message raised by cont2discrete() #20662

budjen-jovan opened this issue May 8, 2024 · 0 comments · Fixed by #20664
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org good first issue Good topic for first contributor pull requests, with a relatively straightforward solution
Milestone

Comments

@budjen-jovan
Copy link
Contributor

Issue with current documentation:

At the end of the function, the error raised is

raise ValueError("Impulse method is only applicable"
                          "to strictly proper systems")

which as a result misses a whitespace between applicable and to

Idea or request for content:

Looking at the way other errors are being raised in the same function, I suggest adding a whitespace at the end of the first string, i.e.

raise ValueError("Impulse method is only applicable "
                          "to strictly proper systems")

Additional context (e.g. screenshots, GIFs)

I'm not sure if this falls under documentation exactly, but it's the closest to what this is, please do let me know if there is an intended way to report this.

@budjen-jovan budjen-jovan added the Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org label May 8, 2024
@tupui tupui added the good first issue Good topic for first contributor pull requests, with a relatively straightforward solution label May 8, 2024
budjen-jovan added a commit to budjen-jovan/scipy that referenced this issue May 8, 2024
As per scipy#20662, fixed the missing blankspace.
j-bowhay pushed a commit that referenced this issue May 8, 2024
@j-bowhay j-bowhay added this to the 1.14.0 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org good first issue Good topic for first contributor pull requests, with a relatively straightforward solution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants