Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binary_opening/binary_closing missing arguments #7453

Closed
jakirkham opened this issue Jun 2, 2017 · 1 comment
Closed

binary_opening/binary_closing missing arguments #7453

jakirkham opened this issue Jun 2, 2017 · 1 comment
Labels
defect A clear bug or issue that prevents SciPy from being installed or used as expected scipy.ndimage
Milestone
1.1.0

Comments

@jakirkham
Copy link
Contributor

As a comparison, binary_dilation provides mask, border_value, and brute_force. While the purpose of brute_force is unclear ( #4586 ), the other two have clear meanings and value for these operations.
@rgommers rgommers added defect A clear bug or issue that prevents SciPy from being installed or used as expected scipy.ndimage labels Jun 5, 2017
@adbugger
Copy link
Contributor

I'd like to take this up and work on it. Looking at the code and the docs, it seems simple enough. The basic erosion and dilation operations are being called with default values for mask, border_value, and brute_force. Arguments can be added to the function definition with these default values.

adbugger added a commit to adbugger/scipy that referenced this issue Mar 11, 2018
@adbugger
Added extra arguments for binary_opening (scipy#7453)
32308b2
adbugger added a commit to adbugger/scipy that referenced this issue Mar 11, 2018
@adbugger
Added arguments to binary_opening function (scipy#7453)
562f689
@adbugger adbugger mentioned this issue Mar 11, 2018
Merged
@rgommers rgommers added this to the 1.1.0 milestone Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect A clear bug or issue that prevents SciPy from being installed or used as expected scipy.ndimage
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
3 participants
@rgommers @jakirkham @adbugger