Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: docstring inconsistency in RectBivariateSpline #9718

Closed
mirca opened this issue Jan 26, 2019 · 2 comments
Closed

DOC: docstring inconsistency in RectBivariateSpline #9718

mirca opened this issue Jan 26, 2019 · 2 comments
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org scipy.interpolate

Comments

@mirca
Copy link
Contributor

mirca commented Jan 26, 2019

The docstring of the smoothing factor s of the class RectBivariateSpline mentions the vector w as part of the estimation condition:

``sum((w[i]*(z[i]-s(x[i], y[i])))**2, axis=0) <= s``

However, it looks like the class RectBivariateSpline doesn't take w as input. I believe this is an inconsistency in the docstring?

@pvanmulbregt pvanmulbregt added scipy.interpolate Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org labels Jan 31, 2019
@erheron
Copy link
Contributor

erheron commented Mar 15, 2020

Hi! I'm looking into this one now, and I've got a feeling that someone, long ago has copied this line from documentation of I don't know, UnivariateSpline class (just my guess), and now it's completely nonsense. I can't see w initialized or used nowhere up to root of inheritance. One more thing is that s is used only in one place:

nx, tx, ny, ty, c, fp, ier = dfitpack.regrid_smth(x, y, z, xb, xe, yb,

and I literally can't find what does regrid_smth do. This w there is bug for sure

@rgommers
Copy link
Member

rgommers commented Apr 6, 2020

Closing in favor of gh-11756. Thanks @mirca and @erheron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org scipy.interpolate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants