MAINT: special: Fix a warning generated when building the AMOS library. #10041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike the other ZBES* functions, in ZBESY the variable R1M5 is not
declared, so its type defaults to REAL*4 (i.e. single precision float).
This means we get a warning when zbesy.f is compiled, because D1MACH
returns a double precision value:
scipy/special/amos/zbesy.f:183:13:
R1M5 = D1MACH(5)
1
Warning: Possible change of value in conversion from REAL(8) to REAL(4) at (1) [-Wconversion]
Presumably this is a mistake. The fix is to add the declaration of
the variable R1M5 as double precision.
(I can hear the Fortran coders out there tsk-tsking and saying
"`IMPLICT NONE` would have caught that!".)
WarrenWeckesser
added
scipy.special
maintenance
|
The failures on TravisCI are #9308. |
|
merged, thanks Warren |
WarrenWeckesser
added
the
Fortran
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the other ZBES* functions, in ZBESY the variable R1M5 is not
declared, so its type defaults to REAL*4 (i.e. single precision float).
This means we get a warning when zbesy.f is compiled, because D1MACH
returns a double precision value:
Presumably this is a mistake. The fix is to add the declaration of
the variable R1M5 as double precision.
(I can hear the Fortran coders out there tsk-tsking and saying
"
IMPLICT NONEwould have caught that!".)