Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: signal: Fix a few build warnings and modernize some C function declarations. #10054

Merged
merged 2 commits into from Apr 12, 2019
Merged

MAINT: signal: Fix a few build warnings and modernize some C function declarations. #10054

merged 2 commits into from Apr 12, 2019

Conversation

WarrenWeckesser
Copy link
Member

No description provided.

@WarrenWeckesser
MAINT: signal: Fix two build warnings in lfilter.c.src.
4155f0e 
* When building with Python 3, there was a pointer variable
  (char *s) that was not used.  The definition of the variable
  was moved into a block contained in the #else-#endif section
  of the #if-#else-#endif preprocesser statement.
* The second argument in a call to `PyArray_SetBase` had to be
  cast to `PyObject *`.
@WarrenWeckesser
MAINT: signal: Modernize the function declarations the bspline util C…
5ec11a8 
… code.

As a side effect, this fixes the warning

    gcc: scipy/signal/D_bspline_util.c
    scipy/signal/C_bspline_util.c:147:12: warning: promoted type 'double' of K&R function parameter is not compatible with the parameter type 'float' declared in a previous prototype [-Wknr-promoted-parameter]
         float precision;
               ^
    scipy/signal/C_bspline_util.c:27:111: note: previous declaration is here
    int C_IIR_forback1(__complex__ float,__complex__ float,__complex__ float*,__complex__ float*,int,int,int,float);
@WarrenWeckesser WarrenWeckesser added maintenance Items related to regular maintenance tasks scipy.signal labels Apr 12, 2019
@rgommers rgommers merged commit d5518b6 into scipy:master Apr 12, 2019
@rgommers rgommers added this to the 1.3.0 milestone Apr 12, 2019
@rgommers
Copy link
Member

thanks Warren

@WarrenWeckesser WarrenWeckesser deleted the signal-warnings branch April 12, 2019 16:43
@WarrenWeckesser WarrenWeckesser added the C/C++ Items related to the internal C/C++ code base label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C/C++ Items related to the internal C/C++ code base maintenance Items related to regular maintenance tasks scipy.signal
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WarrenWeckesser @rgommers