Small speedup in samping from ortho and special_ortho groups #10058
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes 3 changes:
This should be identical up to floating point associativity differences such as between
dot(x, x)
and(x*x).sum()
.np.allclose
is satisfied for everything I've checked althoughnp.array_equal
is not.I timed this on my desktop using only 1 core for
dim
ranging from 2 to 200. Current code is typically 5-15% slower and this tends to shrink for larger dims.Notebook that generated the tests is here
https://github.com/JesseLivezey/scipy-ortho-speedup/blob/master/faster_ortho_groups.ipynb