-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST, MAINT: adjustments for pytest 5.0 #10377
Conversation
* prefer importlib over imp to avoid deprecation warnings since master branch no longer has a support burden for Python 2 * pytest-faulthandler can be removed from infrastructure and docs because it has been merged into pytest core now
e01158a
to
b6d67e1
Compare
The deprecated import is in system Python's distutils:
We'll just have add it to the ignores. |
e2f305a
to
5b54754
Compare
The remaining failure with numpy dev version is #10379 |
Pretty sure I'm going to need to backport this to the |
Might want to upgrade Cython to 0.29.11 for Python 3.8. It's not here yet, but not that far off. |
@charris Do you mean just for the sdist build or also i.e., making additions to @mdhaber Do you know which commit I can backport to resolve the |
@tylerjereddy For sdist now, but it should be stable enough that we can start thinking of testing against it, release schedule is here: https://www.python.org/dev/peps/pep-0569/. The python3.8-dev option is available on travis using xenial, which we should already be doing for 3.7. I should probably try this with NumPy also. |
Put numpy/numpy#14076 up just to see what happens. |
Looks OK except it is running nose tests which gives the 'imp' deprecation warning. We should maybe disable those tests for recent Python and quiet them for pytest. |
The timedelta.total_seconds() has an integer conversion problem, I think it is on the python end of things. |
Fixes #10376 ; may require some iteration since I can't reproduce locally.
prefer importlib over imp to avoid deprecation warnings
since master branch no longer has a support burden for Python 2
pytest-faulthandler can be removed from infrastructure and
docs because it has been merged into pytest core now