BUG: sparse/linalg: fix expm for np.matrix inputs #10906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pv
added
defect
|
Looks good! |
|
Test failures look unrelated, so I'll merge. |
tylerjereddy
pushed a commit
to tylerjereddy/scipy
that referenced
this pull request
Oct 23, 2019
5 tasks
tylerjereddy
removed
the
backport-candidate
tylerjereddy
pushed a commit
to tylerjereddy/scipy
that referenced
this pull request
Jan 20, 2020
tylerjereddy
added a commit
to tylerjereddy/scipy
that referenced
this pull request
Jan 20, 2020
* update SciPy 1.2.3 release notes to include backports for: scipygh-11126, scipygh-10906, scipygh-10633, scipygh-10138, and scipygh-10076. * briefly mention in the notes that this is part of the Python 2.7 LTS support series
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes: gh-5546
What does this implement/fix?
The expm implementation contains code that does not work with np.matrix (at least the MatrixPower linear operator part of it has _rmatvec that assumes self._A is ndarray). This is a minimal fix to avoid problems, by converting matrix inputs to ndarray.
Additional information
Expm returned np.ndarray output for np.matrix input also previously, so there's no behavior change.