BUG: skip deprecation for numpy top-level types #11066
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation decoration of type objects is more likely to cause problems
than for functions, so don't do it. Deprecation of plain functions is
likely enough to result to deprecation warnings in most cases.
This would likely be important to fix for Scipy 1.4.0, as otherwise we break
the backward compatibility here.
E.g. the array scalar type objects are often used in
dtype=
argumentsand possibly compared with other scalar objects, and our deprecation
decoration currently breaks that:
It's possible to do the decoration so that the above still works, via
subclassing with metaclass, but it's hard to be sure that covers everything
necessary. Since deprecation of functions already likely generates deprecation
warnings in suspect code, it's probably enough.