Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: stylistic revision, punctuation, consistency #11157

Merged
merged 10 commits into from
Dec 2, 2019

Conversation

mkg33
Copy link
Contributor

@mkg33 mkg33 commented Dec 1, 2019

This is the last pull request regarding the comprehensive stylistic revision, punctuation correction, and consistency revision in the current documentation.

In case there's another mismatch between the error strings, I already know how to fix it and will do so immediately.

EDIT: there seems to be some issue with mingw (but I've noticed that it's a common problem in the latest pull requests)

Corrected punctuation, stylistic issues and ensured consistency in multiple files.
Corrected punctuation, stylistic issues and ensured consistency in multiple files.
Corrected punctuation and stylistic consistency.
This is the penultimate commit regarding the comprehensive revision of the stylistic consistency in the current documentation.
I fixed the warning messages to match those in the corresponding files.
Found the error, reverted the changes.
Last pull request regarding the comprehensive stylistic revision, punctuation correction, and consistency revision in the documentation.
@mkg33 mkg33 added the Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org label Dec 1, 2019
@rgommers
Copy link
Member

rgommers commented Dec 2, 2019

EDIT: there seems to be some issue with mingw (but I've noticed that it's a common problem in the latest pull requests)

Yes, please ignore those. The server we download from seems to be a bit unreliable, not much we can do about it at the moment.

@rgommers rgommers added the maintenance Items related to regular maintenance tasks label Dec 2, 2019
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mkg33, this is great. Only a couple of comments. I'll merge the PR now (it's so large I only want to review it once!), if you could address the couple of minor comments in a follow-up PR, that would be much appreciated.

scipy/sparse/data.py Show resolved Hide resolved
scipy/special/add_newdocs.py Show resolved Hide resolved
scipy/_lib/_numpy_compat.py Show resolved Hide resolved
@rgommers rgommers merged commit 2ba80dc into scipy:master Dec 2, 2019
@rgommers rgommers added this to the 1.5.0 milestone Dec 2, 2019
mkg33 added a commit to mkg33/scipy that referenced this pull request Dec 2, 2019
Minor stylistic changes that had to be undone from scipygh-11157.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org maintenance Items related to regular maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants