MAINT, DOC: prepare for 1.4.0 "final" release #11221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* set version to 1.4.0 "final" (remove rc2) and set ISRELEASED to False for now
Some tests need slightly higher absolute tolerance in variation of their results on aarch64 compared to the default. The tolerances are all still in the same order of magnitude so fix them up so that tests pass on aarch64 and ppc64le.
The tolerance bump for aarch64 should help ppc64le as well.
test_maxiter_worsening for gmres deviates slightly from 5x best_error on aarch64. Fix this by bumping up the tolerance from 5x to 7x to accommodate for the deviation.
…value selection For real-valued unsymmetric problems, ARPACK can in some cases return one extra eigenvalue. The code that drops the extraneous eigenvalue did not take into account that in shift-invert mode, the which= keyword applies to the *transformed* eigenvalues, and dropped sometimes the wrong eigenvalue. Moreover, fix sort order in this case for 'LM', 'LR', 'LI' modes (largest items come first).
* release notes now account for backported PRs: 11181, 11182, 11199 * remove note indicating that 1.4.0 is not released yet, as we prepare for the final release
tylerjereddy
added
Documentation
rgommers
approved these changes
Dec 16, 2019
|
Alright, backport CI is green & has a reviewer approval, in it goes. We'll deal with conda-forge issues with an external patch if needed for ARM then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains:
1.4.0"final" (removing the rc2) unreleased1.4.0not being releasedOne residual concern I have is the ARM test failure in conda-forge as noted in #11219, but presumably this can be circumvented with a patch provided to @isuruf / their team if needed. I'm pretty sure we still consider our ARM binaries "experimental" at the moment anyway.