-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Prevent crashes due to MKL bug in ?heevr #11737
BUG: Prevent crashes due to MKL bug in ?heevr #11737
Conversation
In the LAPACK wrapper for ?heevr, enlarge the size of the isuppz array parameter in order to prevent out-of-bound access by the underlying library. For both ?heevr and ?syevr, more robust checks and default values are also put in place. Reference: scipy#11709
I haven't reviewed the changes in this PR, so this is just a report on the effect. I am on MacOS 10.12.6. With the master branch of scipy (SHA 1150c4c...) and using numpy from anaconda (so with MKL), I get a seg. fault when I run the |
Fixes multiple crashes on Linux with MKL as well:
|
No there isn't. I just forgot. We need to cleanup a bit a few details but essentially quite doable quickly. I'll have a look. |
Apart from the recent Cython issue, Travis being Travis again hence merging. Feedback from MKL users are welcome. |
In the LAPACK wrapper for ?heevr, enlarge the size of the isuppz array
parameter in order to prevent out-of-bound access by the underlying
library. For both ?heevr and ?syevr, more robust checks and default
values are also put in place.
Reference issue
Closes #11709
What does this implement/fix?
Crashes related to
linalg.eigh()
Additional information
The current status is mostly a workaround for MKL on macos. Further investigation is needed to access the presence or impact of similar issues on other platforms.