WIP: ENH: linalg: add wrapper for ?pbsvx
#11985
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Ah nevermind it's looking for an identical scaling on both sides. Then yes |
Kai-Striega
force-pushed
the
lapack_support_pbsvx
branch
from
828ab58
to
c82ebf4
Compare
|
@mdhaber @Kai-Striega I assume that this is abandoned as the corresponding issue was closed as not planned. Please reopen if I'm mistaken |
lucascolley
changed the title
?pbsvx
|
@lucascolley Yes, I think this can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes issue #11616
What does this implement/fix?
This PR adds a python wrapper for the LAPACK functions {d,s,c,z}pbsvx. These functions solve the linear system of equations Ax = b where A is a Symmetric/Hermitian matrix.
Additional information
?pbsvx comes from a more recent version of lapack than our current minimum. It should therefore not yet be merged.
This PR is missing tests with
equed='Y'. This test requiresAto be multiplied by some scaling factorsi.e.A = diag(s) @ A @ diag(s). The problem I'm having is how do I best generate s? If I were to use a random s, the resultant matrix is (almost certainly) no longer hermitian alternatively I could use ?geequb this returns row, column factors, in that case, how should I convert the row, col factors tos?