BUG: fix newline #12117
Merged
BUG: fix newline #12117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miladsade96
added
scipy.optimize
Documentation
ilayn
approved these changes
May 14, 2020
There was a problem hiding this comment.
@flxai Thanks for this PR. While we are at it, do you mind touching also line 198 to use straight quotes instead of backticks to render best and best1bin as normal text (as in line 208-209). Single backticks are used for internal referencing so that's why it is not rendering correctly.
|
@ilayn Thanks for the suggestion. |
|
The issue in the CI is a Numba error: Numba version 0.49 requires NumPy 1.15 minimum. |
|
@hameerabbasi Does that mean it can be safely ignored? |
|
Yes, it's unrelated to this PR. I will try to make a PR to fix it. |
|
Thanks @flxai, @hameerabbasi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
No issue exists.
What does this implement/fix?
Adds a missing newline in
scipy/optimize/_differentialevolution.pyso the examples' code blocks render correctly.