Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: removed redundant import in SphericalVoronoi tests #12180

Merged
merged 1 commit into from
May 21, 2020
Merged

MAINT: removed redundant import in SphericalVoronoi tests #12180

merged 1 commit into from
May 21, 2020

Conversation

pmla
Copy link
Contributor

@pmla pmla commented May 21, 2020

What does this implement/fix?

The test_spherical_voronoi module imports SphericalVoronoi in two different ways. Here I have removed the redundant import.

@tylerjereddy

@pmla pmla added scipy.spatial maintenance Items related to regular maintenance tasks labels May 21, 2020
@pmla pmla changed the title Removed redundant import in SphericalVoronoi tests MAINT: removed redundant import in SphericalVoronoi tests May 21, 2020
@tylerjereddy tylerjereddy added this to the 1.5.0 milestone May 21, 2020
tylerjereddy
tylerjereddy approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the import was from the early development stages

@tylerjereddy tylerjereddy merged commit 6d69fc8 into scipy:master May 21, 2020
@pmla
Copy link
Contributor Author

pmla commented May 21, 2020

Thanks Tyler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerjereddy tylerjereddy tylerjereddy approved these changes

Assignees
No one assigned
Labels
maintenance Items related to regular maintenance tasks scipy.spatial
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pmla @tylerjereddy