MAINT: Ensure that total function calls is < 'maxfev' #12947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The count of total function calls were checked only after an iteration was completed. This led to an issue due to which the main purpose of option 'maxfev' was defeated. The current change would ensure that the total function evaluations is less than 'maxfev'.
|
Second commit solves the following issue Reference issue See #13011 What does this implement/fix? This will ensure that all local minima data is passed to callback function including that of initial guess and further iterations. |
rgommers
reviewed
Nov 1, 2020
|
Any fix needs a test to verify correctness and avoid regressions. There's more to this story than this two-line fix - I commented on gh-12271. |
|
Both issues that this pr set out to fixed have been fixed now so I think it is safe to close this but thank you for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The count of total function calls were checked only after an iteration was completed. This led to an issue due to which the main purpose of option 'maxfev' was defeated. The current change would ensure that the total function evaluations is less than 'maxfev'.
Reference issue
See #12271
What does this implement/fix?
Ensures that the 'maxfev' option is not violated.