Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Port coverage, 64-bit BLAS, GCC 4.8 build to azure #13138

Merged
merged 3 commits into from Nov 28, 2020
Merged

CI: Port coverage, 64-bit BLAS, GCC 4.8 build to azure #13138

merged 3 commits into from Nov 28, 2020

Conversation

peterbell10
Copy link
Member

Reference issue

Ref gh-13134

What does this implement/fix?

Experimenting with Azure templates as a way to replace the TravisCI build script.

@peterbell10 peterbell10 added the CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure label Nov 25, 2020
@peterbell10 peterbell10 force-pushed the azure-travis branch 18 times, most recently from 42b39ef to a8d32e6 Compare November 26, 2020 13:43
@peterbell10 peterbell10 marked this pull request as ready for review November 26, 2020 14:51
@peterbell10 peterbell10 changed the title CI: Use templates for azure travis-replacement jobs CI: Port coverage, 64-bit BLAS, GCC 4.8 build to azure Nov 26, 2020
@peterbell10
Copy link
Member Author

This ports the last of the x86 buidls from travis (except python-debug which is #13136). The GCC-4.8 build has even caught a real build failure with the LSAP module.

@peterbell10
Copy link
Member Author

peterbell10 commented Nov 26, 2020 •
edited

Had to update the coverage upload, this azure blog post say to use https://codecov.io/bash instead of running codecov. With that, the upload is now working:
https://codecov.io/gh/scipy/scipy/tree/c4c9d4add1292bdded8ceec3db2bcbeb3a9b35dc

Adding another commit also shows that ccache is working properly as well, reducing build times to ~1-2 min:
https://dev.azure.com/scipy-org/SciPy/_build/results?buildId=9308&view=logs&jobId=17aca2f3-ee30-5520-7bc7-5bc1195fd45e&j=4c925117-6155-59c4-749e-aa25fa289e87&t=9f9c4fba-a4ed-56d2-0ab2-86524a9235bc

@rgommers
Copy link
Member

This looks pretty good to me!

rgommers
rgommers approved these changes Nov 28, 2020
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through this again in more detail. All CI output for both jobs looks good. So let's get this in before it accumulates a merge conflict.

Thanks @peterbell10!

@rgommers rgommers merged commit 0fdfe6e into scipy:master Nov 28, 2020
@rgommers rgommers added this to the 1.6.0 milestone Nov 28, 2020
@peterbell10 peterbell10 deleted the azure-travis branch November 28, 2020 15:08
@peterbell10 peterbell10 mentioned this pull request Nov 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterbell10 @rgommers