DOC: fix runtests guidelines. #13445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To retrigger CI. I think an unrelated test was failing on master when this built, but that has been patched. |
tylerjereddy
added
the
Documentation
There was a problem hiding this comment.
Based on the discussion in the matching issue, using the Python-name approach as per the changes here does seem a bit less likely to fail since it should work for both in-place builds and tests of installed builds without having to specify long absolute paths to build dir modules.
|
Seems a bit more resilient to the mode of SciPy build/installation, and CI is green, so let's try this doc update. |
|
Thanks @V0lantis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Fixes #13440.
What does this implement/fix?
This changes runtests guidelines. The argument to the -t option should be a Python name (i.e. a dotted Python module path), not a file path.