New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD: remove build_sphinx support from setup.py #13519
Conversation
The circleci |
correct
yeah it's been failing for a couple of days, no time to look into it today unfortunately |
Thanks @V0lantis! Given that it's unrelated to this PR, could you open a new issue for it? The critical part is this probably:
CI is set up to error when there are any warnings, so we keep the build clean. Those warnings will be higher up, so you may want to attach the full build log for that CI step (that's doable either as a gist, or with a foldout as I just did to your comment above - surround the code block with |
CI issue resolved, all green now - I'll merge this in a day or two unless there's more comments. |
Looks straightforward so I'll merge, thanks @rgommers |
Closes gh-3284