MAINT: add a type-ignore for mpmath (#13721) #13721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WarrenWeckesser
added
maintenance
Co-authored-by: Tirth Patel <tirthasheshpatel@gmail.com>
Co-authored-by: Tirth Patel <tirthasheshpatel@gmail.com>
tirthasheshpatel
approved these changes
Mar 22, 2021
rgommers
approved these changes
Mar 22, 2021
rgommers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
N/A
What does this implement/fix?
When I merged A gh-10170 there were some mypy typing changes (and a couple spaces I missed).
The mypy issue breaks the python3.9 CPython nightly build.
This changes here are based on discussions and related changes in
#13613 (comment)
Additional information
We may want to keep the
speciallevel ignore error inmypy.iniand remove the inline changes, or according to mypy docs we can use justthe inline ignore comments.