POC: Build windows with vs2019 #13758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -198,7 +198,7 @@ jobs: | |||
| - job: Windows | |||
| condition: and(succeeded(), ne(variables['Build.SourceBranch'], 'refs/heads/master')) # skip for PR merges | |||
| pool: | |||
| vmImage: 'VS2017-Win2016' | |||
| vmImage: 'windows-2019' | |||
There was a problem hiding this comment.
One question--do the Windows builds in our wheels repo "match" well to this? In other words, this won't affect the likelihood that Windows issues slip through until they're caught in the wheels building repo?
There was a problem hiding this comment.
The wheel repo will have to be adjusted to this as well. I was trying to gather this information accurately in #13713, but it seems that the build location of the windows wheels was not correct.
In any case, this is for now intended to just be what it says on the label - a proof-of-concept.
tylerjereddy
added
the
CI
|
In light of the new warning on azure, this takes on some additional significance: |
|
As of #14832, this has become obsolete 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #13713 as discussed. This should be on hold until the concerns raised in conda-forge/scipy-feedstock#165 are resolved.