Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add Gitpod documentation #13871

Merged
merged 10 commits into from Apr 19, 2021
Merged

DOC: Add Gitpod documentation #13871

merged 10 commits into from Apr 19, 2021

Conversation

trallard
Copy link
Member

@trallard trallard commented Apr 15, 2021

Reference issue

Related to PR #13854

What does this implement/fix?

  • Adds developer documentation for Gitpod

Additional information

@trallard trallard added Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org gitpod labels Apr 15, 2021
Copy link
Contributor

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through out of curiosity since I've never used Gitpod. Actually, I got stuck trying to find the "Gitpod button" in GitHub--maybe I'm missing something or there's another step needed in docs?

doc/source/dev/contributor/quickstart_gitpod.rst Outdated Show resolved Hide resolved
@trallard
Copy link
Member Author

Ah found it - when you install Gitpod (of course) it asks you for permissions to access repos (see below)

Installing_gitpod_io

You can override the installation or change your access from your Gitpod Integration dashboard. Will add this in the docs thanks for raising this @tylerjereddy

@trallard
Copy link
Member Author

Added a section on installing the Gitpod app as well as a part in the FAQ on how to fix this issue

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @trallard. A number of small comments, nothing major.

doc/source/dev/contributor/quickstart_gitpod.rst Outdated Show resolved Hide resolved
doc/source/dev/contributor/quickstart_gitpod.rst Outdated Show resolved Hide resolved
doc/source/dev/contributor/quickstart_gitpod.rst Outdated Show resolved Hide resolved
doc/source/dev/contributor/quickstart_gitpod.rst Outdated Show resolved Hide resolved
doc/source/dev/contributor/quickstart_gitpod.rst Outdated Show resolved Hide resolved
doc/source/dev/contributor/quickstart_gitpod.rst Outdated Show resolved Hide resolved
doc/source/dev/contributor/quickstart_gitpod.rst Outdated Show resolved Hide resolved
doc/source/dev/contributor/quickstart_gitpod.rst Outdated Show resolved Hide resolved
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green now, so let's get this in. Looks great, thanks @trallard!

@rgommers rgommers merged commit cb88079 into scipy:master Apr 19, 2021
@rgommers rgommers added this to the 1.7.0 milestone Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants