Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC:interpolate: Fix the docstring example of "lagrange" #14413

Merged
merged 7 commits into from Jul 16, 2021

Conversation

Jebby993
Copy link
Contributor

@Jebby993 Jebby993 commented Jul 14, 2021

Reference issue

Closes #14409

What does this implement/fix?

Fix interpolate.lagrange documentation

Additional information

Fix use of Polynomial class

@Jebby993 Jebby993 requested a review from ev-br as a code owner July 14, 2021 14:17
Copy link
Member

@ev-br ev-br left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo two comments. Please just push a next commit into the same branch, it'll get picked up by github

scipy/interpolate/interpolate.py Outdated Show resolved Hide resolved
scipy/interpolate/interpolate.py Outdated Show resolved Hide resolved
@ev-br ev-br added Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org scipy.interpolate labels Jul 14, 2021
@ev-br ev-br added this to the 1.8.0 milestone Jul 14, 2021
@ev-br ev-br changed the title Close#14409 Fix the docstring example of scipy.interpolate.largrange Jul 14, 2021
@Jebby993 Jebby993 requested a review from ev-br July 14, 2021 16:14
@ilayn ilayn changed the title Fix the docstring example of scipy.interpolate.largrange DOC:interpolate: Fix the docstring example of "lagrange" Jul 15, 2021
@ev-br ev-br merged commit cb0700e into scipy:master Jul 16, 2021
@ev-br
Copy link
Member

ev-br commented Jul 16, 2021

LGTM now. Doc build is green, MacOS CI failures are likely unrelated, so merging. Thanks @Jebby993 and looking forward for further PRs on you!

ragibson pushed a commit to ragibson/scipy that referenced this pull request Jul 25, 2021
Smit-create pushed a commit to Smit-create/scipy that referenced this pull request Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org scipy.interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lagrange polynomials and numpy Polynomials
2 participants