Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Added test for strided inputs in sepfir2d #14558

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Smit-create
Copy link
Member

[38.942419, 36.574301, 37.060368, 37.403998],
[37.563456, 35.758501, 33.46929 , 30.447159],
[24.466602, 23.506581, 24.316481, 19.806113]])
assert_allclose(signal.sepfir2d(image, filt, filt[::3]), expected)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MacOS CI failure looks related at least:

=================================== FAILURES ===================================
________________________________ test_sepfir2d _________________________________
scipy/signal/tests/test_bsplines.py:267: in test_sepfir2d
    assert_allclose(signal.sepfir2d(image, filt, filt[::3]), expected)
E   AssertionError: 
E   Not equal to tolerance rtol=1e-07, atol=0
E   
E   Mismatched elements: 2 / 16 (12.5%)
E   Max absolute difference: 31.99999962
E   Max relative difference: 1.02353683

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I need to do something else for MacOS. Locally, running the tests for signal submodule on Linux passes for me:

scipy/signal/tests/test_bsplines.py::test_sepfir2d PASSED                [  0%]
...
============== 2787 passed, 2 skipped, 10475 deselected in 53.99s ==============

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This passes for me on macOS 11 with the conda compilers. The issue may be specific to GCC.

@Smit-create
Copy link
Member Author

Please have a look at this. @rgommers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks scipy.signal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants