Change description of 'Wn' and 'fs' for iirfilter function #14562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerjereddy
added
scipy.signal
Documentation
tylerjereddy
reviewed
Aug 8, 2021
| @@ -2298,6 +2298,8 @@ def iirfilter(N, Wn, rp=None, rs=None, btype='band', analog=False, | |||
|
|
|||
| fs : float, optional | |||
| The sampling frequency of the digital system. | |||
| If it is specified then units of 'fs' and 'Wn' will be the same i.e. half-cycles/sample. | |||
There was a problem hiding this comment.
Minor complaint from the CI tests: scipy/signal/filter_design.py:2301:80: E501 line too long (96 > 79 characters)
There was a problem hiding this comment.
Well, this is my first contribution.
Do I have to make another and then give another pull request ?
No, you can push changes in to your current pull request feature branch, so this can stay open while you work on it. One suggestion--you may want to use a branch other than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
What does this implement/fix?
Additional information