Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: fix documentation for scipy.optimize.brenth #14729

Merged
merged 2 commits into from
Nov 10, 2021

Conversation

BSGalvan
Copy link
Contributor

Reference issue

Closes GitHub Issue #14390

What does this implement/fix?

This commit fixes the documentation for scipy.optimize.brenth, providing a proper citation along with some additional information about the algorithm used.

Additional information

Relevant papers for double-checking:
1.) Original paper
2.) Subsequent paper describing the method as "similar to Brent's method, but with hyperbolic interpolation".

@BSGalvan BSGalvan changed the title Fix #14390 DOC: fix documentation for scipy.optimize.brenth Sep 14, 2021
@tylerjereddy tylerjereddy added the Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org label Sep 15, 2021
scipy/optimize/zeros.py Outdated Show resolved Hide resolved
scipy/optimize/zeros.py Outdated Show resolved Hide resolved
BSGalvan and others added 2 commits November 10, 2021 14:04
See scipy#14390. This commit adds a proper reference for the brenth method,
along with the necessary citation.
Move See Also section to the correct place, and fix the DOI
link by using the `:doi:` directive.
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks @BSGalvan!

Rebased and added some cleanups, merging.

@rgommers rgommers merged commit d0e42b5 into scipy:master Nov 10, 2021
@rgommers rgommers added this to the 1.8.0 milestone Nov 10, 2021
@BSGalvan
Copy link
Contributor Author

This LGTM, thanks @BSGalvan!

Rebased and added some cleanups, merging.

Awesome, happy I could help :D
Thanks for the cleanup, still very new to reST!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org scipy.optimize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants