Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Review _assert_within_tol positional arguments #15087

Merged
merged 9 commits into from Dec 2, 2021

Commits on Nov 23, 2021

  1. TST: Review _assert_within_tol positional arguments

    ``_assert_within_tol`` is often called with positional
     arguments that end up being filled into the signature,
     e.g. calls to ``_assert_within_tol(Y1, Y2, eps, verbose > 2)``
     evaluate to calls where `atol=eps` and `rtol=verbose > 2`.
    
     This PR converts calls to using keywords where needed. Further
     it modifies some tolerances to be stricter.
    Kai-Striega committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    7104f8f View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. Configuration menu
    Copy the full SHA
    192c768 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    623f6f4 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2021

  1. TST: Remove _asert_within_tol helper function

    ``_assert_within_tol`` provided a wrapper for ``assert_allclose``. This behavior
    is already available from ``assert_allclose`` which is now used instead.
    Kai-Striega committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    1bc855f View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2021

  1. TST: Use atol for test_pdist_cosine_iris_* tests

    `atol` leads the tests to pass allowing the changes to the other
    tests to be included in the 1.8 branch. This way some improvements
    are included with the remaining test fine-tuning to be completed
    after the branch.
    Kai-Striega committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    3a6faa4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d3bdc48 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c382bdf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    229b658 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    abbfda5 View commit details
    Browse the repository at this point in the history