MAINT: Fix imports in signal._signaltools
#15275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smit-create
added
maintenance
rgommers
approved these changes
Dec 24, 2021
There was a problem hiding this comment.
No idea why this wasn't failing before - happy to not investigate further though:)
Thanks for the fixes @Smit-create
rgommers
added
the
backport-candidate
tylerjereddy
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why the following line does not fail on the master when there is no module named
dlti( which is actually a class defined in_ltisys.py)This same line raised an import error when I was working on rgommers#101.
scipy/scipy/signal/_signaltools.py
Line 8 in bdefc81
cc @rgommers